Changeset 2834

Timestamp:

08/22/07 06:19:22 (1 year ago)

Author:

jeresig

Message:

Fixed use of eval() and new Function() to work within the correct scope (and not throw errors).

Location:

trunk/jquery/src

Files:

• jquery/jquery.js (modified) (2 diffs)
• selector/selector.js (modified) (1 diff)

trunk/jquery/src/jquery/jquery.js

@@ -1858 +1858 @@
         // for it (a handy shortcut)
         if ( typeof fn == "string" )
-            fn = eval("function(a,i){return " + fn + "}");
+            fn = eval("false||function(a,i){return " + fn + "}");
 
         var result = [];
@@ -1912 +1912 @@
         // for it (a handy shortcut)
         if ( typeof fn == "string" )
-            fn = eval("function(a){return " + fn + "}");
+            fn = eval("false||function(a){return " + fn + "}");
 
         var result = [];

trunk/jquery/src/selector/selector.js

@@ -406 +406 @@
 
                 // Build a custom macro to enclose it
-                eval("f = function(a,i){return " + f + "}");
+                f = eval("false||function(a,i){return " + f + "}");
 
                 // Execute it against the current filter