Changeset 3856

Timestamp:

11/19/07 16:07:44 (9 months ago)

Author:

brandon.aaron

Message:

Fix for #1944. Added nodeName and tagName to jQuery.props and tests for maxlength, defaultValue, selectedIndex, tagName and nodeName.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/index.html (modified) (2 diffs)
• test/unit/core.js (modified) (4 diffs)

trunk/jquery/src/core.js

@@ -1207 +1207 @@
         maxlength: "maxLength",
         selectedIndex: "selectedIndex",
-        defaultValue: "defaultValue"
+        defaultValue: "defaultValue",
+        tagName: "tagName",
+        nodeName: "nodeName"
     }
 });

trunk/jquery/test/index.html

@@ -41 +41 @@
         <ol id="empty"></ol>
         <form id="form" action="formaction">
-            <input type="text" name="action" value="Test" id="text1"/>
+            <input type="text" name="action" value="Test" id="text1" maxlength="30"/>
             <input type="text" name="text2" value="Test" id="text2" disabled="disabled"/>
             <input type="radio" name="radio1" id="radio1" value="on"/>
@@ -56 +56 @@
             <button id="button" name="button">Button</button>
             
-            <textarea id="area1">foobar</textarea>
+            <textarea id="area1" maxlength="30">foobar</textarea>
             
             <select name="select1" id="select1">

trunk/jquery/test/unit/core.js

@@ -224 +224 @@
 
 test("attr(String)", function() {
-    expect(13);
+    expect(20);
     ok( $('#text1').attr('value') == "Test", 'Check for value attribute' );
+    ok( $('#text1').attr('value', "Test2").attr('defaultValue') == "Test", 'Check for defaultValue attribute' );
     ok( $('#text1').attr('type') == "text", 'Check for type attribute' );
     ok( $('#radio1').attr('type') == "radio", 'Check for type attribute' );
@@ -237 +238 @@
     ok( $('#text1').attr('name') == "action", 'Check for name attribute' );
     ok( $('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
+    ok( $('#text1').attr('maxlength') == '30', 'Check for maxlength attribute' );
+    ok( $('#text1').attr('maxLength') == '30', 'Check for maxLength attribute' );
+    ok( $('#area1').attr('maxLength') == '30', 'Check for maxLength attribute' );
+    ok( $('#select2').attr('selectedIndex') == 3, 'Check for selectedIndex attribute' );
+    ok( $('#foo').attr('nodeName') == 'DIV', 'Check for nodeName attribute' );
+    ok( $('#foo').attr('tagName') == 'DIV', 'Check for tagName attribute' );
     
     $('<a id="tAnchor5"></a>').attr('href', '#5').appendTo('#main'); // using innerHTML in IE causes href attribute to be serialized to the full path
@@ -270 +277 @@
 
 test("attr(String, Object)", function() {
-    expect(12);
+    expect(13);
     var div = $("div");
     div.attr("foo", "bar");
@@ -293 +300 @@
     $("#name").attr('maxlength', '5');
     ok( document.getElementById('name').maxLength == '5', 'Set maxlength attribute' );
+    $("#name").attr('maxLength', '10');
+    ok( document.getElementById('name').maxLength == '10', 'Set maxlength attribute' );
 
     reset();