Changeset 4014

Timestamp:

12/04/07 19:37:03 (1 year ago)

Author:

davidserduke

Message:

Fixed #1763 by checking to see if .createElement() is available on the context and if isn't default to other contexts.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/core.js (modified) (3 diffs)

trunk/jquery/src/core.js

@@ -918 +918 @@
         var ret = [];
         context = context || document;
+        if (!context.createElement) 
+            context = context.ownerDocument || context[0] && context[0].ownerDocument || document;
 
         jQuery.each(elems, function(i, elem){

trunk/jquery/test/unit/core.js

@@ -13 +13 @@
 
 test("$()", function() {
-    expect(5);
+    expect(4);
     
     var main = $("#main");
     isSet( $("div p", main).get(), q("sndp", "en", "sap"), "Basic selector with jQuery object as context" );
     
+/*
+    // disabled since this test was doing nothing. i tried to fix it but i'm not sure
+    // what the expected behavior should even be. FF returns "\n" for the text node
     // make sure this is handled
-    $('<p>\r\n</p>');
-    ok( true, "Check for \\r and \\n in jQuery()" );
+    var crlfContainer = $('<p>\r\n</p>');
+    var x = crlfContainer.contents().get(0).nodeValue;
+    equals( x, what???, "Check for \\r and \\n in jQuery()" );
+*/
     
     /* // Disabled until we add this functionality in
@@ -149 +154 @@
 test("$('html')", function() {
     expect(4);
-    
+
     reset();
     foo = false;
@@ -162 +167 @@
     
     reset();
+});
+
+test("$('html', context)", function() {
+    expect(1);
+
+    var $div = $("<div/>");
+    var $span = $("<span/>", $div);
+    equals($span.length, 1, "Verify a span created with a div context works");
 });