Changeset 4031

Timestamp:

12/05/07 05:01:46 (1 year ago)

Author:

davidserduke

Message:

Fixed #1419 where IE failed with .text() on an XML node. This is part of a series of tickets including #1264 where the context of the DOM manipulation was a problem in xml and iframe documents.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/core.js (modified) (2 diffs)

trunk/jquery/src/core.js

@@ -918 +918 @@
         var ret = [];
         context = context || document;
-        if (!context.createElement) 
+        // !context.createElement fails in IE with an error but returns typeof 'object'
+        if (typeof context.createElement == 'undefined') 
             context = context.ownerDocument || context[0] && context[0].ownerDocument || document;
 

trunk/jquery/test/unit/core.js

@@ -174 +174 @@
     var $div = $("<div/>");
     var $span = $("<span/>", $div);
-    equals($span.length, 1, "Verify a span created with a div context works");
+    equals($span.length, 1, "Verify a span created with a div context works, #1763");
+});
+
+test("$(selector, xml).text(str) - Loaded via XML document", function() {
+    expect(2);
+    stop();
+    $.get('data/dashboard.xml', function(xml) { 
+        // tests for #1419 where IE was a problem
+        equals( $("tab:first", xml).text(), "blabla", "Verify initial text correct" );
+        $("tab:first", xml).text("newtext");
+        equals( $("tab:first", xml).text(), "newtext", "Verify new text correct" );
+        start();
+    });
 });
 
@@ -356 +368 @@
                     titles.push($(this).attr('title'));
               });
-              ok( titles[0] == 'Location', 'attr() in XML context: Check first title' );
-              ok( titles[1] == 'Users', 'attr() in XML context: Check second title' );
+              equals( titles[0], 'Location', 'attr() in XML context: Check first title' );
+              equals( titles[1], 'Users', 'attr() in XML context: Check second title' );
               start();
         });