Changeset 4171

Timestamp:

12/16/07 01:03:50 (9 months ago)

Author:

davidserduke

Message:

Fixed #1781 for warnings created on load by FF javascript.options.strict == true.

Location:

trunk/jquery/src

Files:

• ajax.js (modified) (3 diffs)
• core.js (modified) (2 diffs)
• event.js (modified) (10 diffs)
• fx.js (modified) (1 diff)
• offset.js (modified) (2 diffs)

trunk/jquery/src/ajax.js

@@ -247 +247 @@
 
             // We handle everything using the script element injection
-            return;
+            return undefined;
         }
 
@@ -362 +362 @@
         if ( !s.async )
             onreadystatechange();
-        
-        // return XMLHttpRequest to allow aborting the request etc.
-        return xml;
 
         function success(){
@@ -389 +386 @@
                 jQuery.event.trigger( "ajaxStop" );
         }
+        
+        // return XMLHttpRequest to allow aborting the request etc.
+        return xml;
     },
 

trunk/jquery/src/core.js

@@ -419 +419 @@
             }
 
-        } else
-            return this.each(function(){
-                if ( this.nodeType != 1 )
-                    return;
-
-                if ( value.constructor == Array && /radio|checkbox/.test( this.type ) )
-                    this.checked = (jQuery.inArray(this.value, value) >= 0 ||
-                        jQuery.inArray(this.name, value) >= 0);
-
-                else if ( jQuery.nodeName( this, "select" ) ) {
-                    var values = value.constructor == Array ?
-                        value :
-                        [ value ];
-
-                    jQuery( "option", this ).each(function(){
-                        this.selected = (jQuery.inArray( this.value, values ) >= 0 ||
-                            jQuery.inArray( this.text, values ) >= 0);
-                    });
-
-                    if ( !values.length )
-                        this.selectedIndex = -1;
-
-                } else
-                    this.value = value;
-            });
+        }
+
+        return this.each(function(){
+            if ( this.nodeType != 1 )
+                return;
+
+            if ( value.constructor == Array && /radio|checkbox/.test( this.type ) )
+                this.checked = (jQuery.inArray(this.value, value) >= 0 ||
+                    jQuery.inArray(this.name, value) >= 0);
+
+            else if ( jQuery.nodeName( this, "select" ) ) {
+                var values = value.constructor == Array ?
+                    value :
+                    [ value ];
+
+                jQuery( "option", this ).each(function(){
+                    this.selected = (jQuery.inArray( this.value, values ) >= 0 ||
+                        jQuery.inArray( this.text, values ) >= 0);
+                });
+
+                if ( !values.length )
+                    this.selectedIndex = -1;
+
+            } else
+                this.value = value;
+        });
     },
     
@@ -972 +973 @@
                             [];
                 
-                    for ( var i = tbody.length - 1; i >= 0 ; --i )
-                        if ( jQuery.nodeName( tbody[ i ], "tbody" ) && !tbody[ i ].childNodes.length )
-                            tbody[ i ].parentNode.removeChild( tbody[ i ] );
+                    for ( var j = tbody.length - 1; j >= 0 ; --j )
+                        if ( jQuery.nodeName( tbody[ j ], "tbody" ) && !tbody[ j ].childNodes.length )
+                            tbody[ j ].parentNode.removeChild( tbody[ j ] );
                     
                     // IE completely kills leading whitespace when innerHTML is used    

trunk/jquery/src/event.js

@@ -171 +171 @@
             // don't do events on text and comment nodes
             if ( element.nodeType == 3 || element.nodeType == 8 )
-                return;
+                return undefined;
 
             var val, ret, fn = jQuery.isFunction( element[ type ] || null ),
@@ -333 +333 @@
                 // If Safari or IE is used
                 // Continually check to see if the document is ready
-                if  (jQuery.browser.msie || jQuery.browser.safari ) (function(){
+                if (jQuery.browser.msie || jQuery.browser.safari ) (function(){
                     try {
                         // If IE is used, use the trick by Diego Perini
@@ -340 +340 @@
                             document.documentElement.doScroll("left");
                     } catch( error ) {
-                        return setTimeout( arguments.callee, 0 );
+                        setTimeout( arguments.callee, 0 );
+                        return;
                     }
 
@@ -368 +369 @@
                 if (jQuery.browser.msie) return false;
                 jQuery(this).bind('mouseover', jQuery.event.special.mouseenter.handler);
+                return true;
             },
         
@@ -373 +375 @@
                 if (jQuery.browser.msie) return false;
                 jQuery(this).unbind('mouseover', jQuery.event.special.mouseenter.handler);
+                return true;
             },
             
@@ -378 +381 @@
                 var args = Array.prototype.slice.call( arguments, 1 );
                 // If we actually just moused on to a sub-element, ignore it
-                if ( withinElement(event, this) ) return;
+                if ( withinElement(event, this) ) return true;
                 // Execute the right handlers by setting the event type to mouseenter
                 event.type = 'mouseenter';
@@ -392 +395 @@
                 if (jQuery.browser.msie) return false;
                 jQuery(this).bind('mouseout', jQuery.event.special.mouseleave.handler);
+                return true;
             },
         
@@ -397 +401 @@
                 if (jQuery.browser.msie) return false;
                 jQuery(this).unbind('mouseout', jQuery.event.special.mouseleave.handler);
+                return true;
             },
             
@@ -402 +407 @@
                 var args = Array.prototype.slice.call( arguments, 1 );
                 // If we actually just moused on to a sub-element, ignore it
-                if ( withinElement(event, this) ) return false;
+                if ( withinElement(event, this) ) return true;
                 // Execute the right handlers by setting the event type to mouseleave
                 event.type = 'mouseleave';
@@ -445 +450 @@
         if ( this[0] )
             return jQuery.event.trigger( type, data, this[0], false, fn );
+        return undefined;
     },
 

trunk/jquery/src/fx.js

@@ -182 +182 @@
 var queue = function( elem, type, array ) {
     if ( !elem )
-        return;
+        return undefined;
 
     type = type || "fx";

trunk/jquery/src/offset.js

@@ -86 +86 @@
     }
 
-    return results;
-
     function border(elem) {
         add( jQuery.css(elem, "borderLeftWidth"), jQuery.css(elem, "borderTopWidth") );
@@ -96 +94 @@
         top += parseInt(t) || 0;
     }
+
+    return results;
 };