Changeset 4196 for trunk/jquery

Timestamp:

12/17/07 01:58:05 (1 year ago)

Author:

davidserduke

Message:

Fixed #2037 where Opera would mis-state the value of 'display' after an innerHTML was done in some cases.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/index.html (modified) (1 diff)
• test/unit/core.js (modified) (2 diffs)

trunk/jquery/src/core.js

@@ -816 +816 @@
                 "1" :
                 ret;
+        }
+        // Opera sometimes will give the wrong display answer, this fixes it, see #2037
+        if ( jQuery.browser.opera && name == "display" ) {
+            var save = elem.style.display;
+            elem.style.display = "block";
+            elem.style.display = save;
         }
         

trunk/jquery/test/index.html

@@ -173 +173 @@
             </form>
             <div id="nonnodes"><span>hi</span> there <!-- mon ami --></div>
+            <div id="t2037">
+                <div><div class="hidden">hidden</div></div>
+            </div>
         </div>
     </div>

trunk/jquery/test/unit/core.js

@@ -421 +421 @@
 
 test("css(String, Object)", function() {
-    expect(20);
+    expect(21);
     ok( $('#foo').is(':visible'), 'Modifying CSS display: Assert element is visible');
     $('#foo').css('display', 'none');
@@ -455 +455 @@
     j.css("padding-left", "1px");
     equals( j.css("padding-left"), "1px", "Check node,textnode,comment css works" );
+
+    // opera sometimes doesn't update 'display' correctly, see #2037
+    $("#t2037")[0].innerHTML = $("#t2037")[0].innerHTML
+    equals( $("#t2037 .hidden").css("display"), "none", "Make sure browser thinks it is hidden" );
 });