Changeset 4206

Timestamp:

12/17/07 16:54:44 (8 months ago)

Author:

davidserduke

Message:

Fixed #2062 by adding a check to see if the selector is array-like in .not() before testing it as an array. Otherwise it does a straight comparison during the filter test.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/core.js (modified) (1 diff)

trunk/jquery/src/core.js

@@ -354 +354 @@
 
         return this.filter(function() {
-            return jQuery.inArray( this, selector ) < 0;
+            // check to see if the selector is array-like otherwise assume it is just a DOM element
+            return ( selector.length && selector[selector.length - 1] !== undefined )
+                ? jQuery.inArray( this, selector ) < 0
+                : this != selector;
         });
     },

trunk/jquery/test/unit/core.js

@@ -1059 +1059 @@
 
 test("not()", function() {
-    expect(5);
+    expect(7);
     ok( $("#main > p#ap > a").not("#google").length == 2, "not('selector')" );
+    ok( $("#main > p#ap > a").not(document.getElementById("google")).length == 2, "not(DOMElement)" );
     isSet( $("p").not(".result").get(), q("firstp", "ap", "sndp", "en", "sap", "first"), "not('.class')" );
     isSet( $("p").not("#ap, #sndp, .result").get(), q("firstp", "en", "sap", "first"), "not('selector, selector')" );
     isSet( $("p").not($("#ap, #sndp, .result")).get(), q("firstp", "en", "sap", "first"), "not(jQuery)" );
+    ok( $("p").not(document.getElementsByTagName("p")).length == 0, "not(Array-like DOM collection)" );
     isSet( $("#form option").not("option.emptyopt:contains('Nothing'),[selected],[value='1']").get(), q("option1c", "option1d", "option2c", "option3d" ), "not('complex selector')");
 });