Changeset 4212

Timestamp:

12/17/07 21:02:05 (9 months ago)

Author:

davidserduke

Message:

Fixed #2070 by adding a test for !nodeType to isArrayLike so DOM elements like SELECT are not considered array-like (even though they really are).

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/core.js (modified) (1 diff)

trunk/jquery/src/core.js

@@ -353 +353 @@
                 selector = jQuery.multiFilter( selector, this );
 
+        var isArrayLike = selector.length && selector[selector.length - 1] !== undefined && !selector.nodeType;
         return this.filter(function() {
-            // check to see if the selector is array-like otherwise assume it is just a DOM element
-            return ( selector.length && selector[selector.length - 1] !== undefined )
-                ? jQuery.inArray( this, selector ) < 0
-                : this != selector;
+            return isArrayLike ? jQuery.inArray( this, selector ) < 0 : this != selector;
         });
     },

trunk/jquery/test/unit/core.js

@@ -1069 +1069 @@
     
     var selects = $("#form select");
-    isSet( selects.not( selects[1] ), ["select1", "select3"], "filter out DOM element");
+    isSet( selects.not( selects[1] ), q("select1", "select3"), "filter out DOM element");
 });