Changeset 4251

Timestamp:

12/20/07 13:36:56 (8 months ago)

Author:

jeresig

Message:

Fixed #2027 - make sure that cloned elements (within appendTo, etc.) have their events cloned by default.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/event.js (modified) (2 diffs)

trunk/jquery/src/core.js

@@ -499 +499 @@
             jQuery.each(elems, function(){
                 var elem = clone ?
-                    this.cloneNode( true ) :
+                    jQuery( this ).clone( true )[0] :
                     this;
 

trunk/jquery/test/unit/event.js

@@ -2 +2 @@
 
 test("bind()", function() {
-    expect(18);
+    expect(19);
 
     var handler = function(event) {
@@ -86 +86 @@
         equals(this.nodeType, 1, "Check node,textnode,comment bind just does real nodes" );
     }).trigger("tester");
+
+    // Make sure events stick with appendTo'd elements (which are cloned) #2027
+    $("<a href='#fail' class='test'>test</a>").click(function(){ return false; }).appendTo("p");
+    ok( $("a.test:first").triggerHandler("click") === false, "Handler is bound to appendTo'd elements" );
+    reset();
 });