Changeset 4513

Timestamp:

01/23/08 03:54:23 (6 months ago)

Author:

davidserduke

Message:

Fix #2184 by using the jQuery.clean() function instead of a direct innerHTML assignment in the clone() function for IE.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/core.js (modified) (1 diff)

trunk/jquery/src/core.js

@@ -304 +304 @@
                 // the name attribute on an input).
                 var clone = this.cloneNode(true),
-                    container = document.createElement("div"),
-                    container2 = document.createElement("div");
+                    container = document.createElement("div");
                 container.appendChild(clone);
-                container2.innerHTML = container.innerHTML;
-                return container2.firstChild;
+                return jQuery.clean([container.innerHTML])[0];
             } else
                 return this.cloneNode(true);

trunk/jquery/test/unit/core.js

@@ -956 +956 @@
 
 test("clone()", function() {
-    expect(4);
+    expect(20);
     ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Assert text for #en' );
     var clone = $('#yahoo').clone();
     ok( 'Try them out:Yahoo' == $('#first').append(clone).text(), 'Check for clone' );
     ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Reassert text for #en' );
+
+    var cloneTags = [ 
+        "<table/>", "<tr/>", "<td/>", "<div/>", 
+        "<button/>", "<ul/>", "<ol/>", "<li/>",
+        "<input type='checkbox' />", "<select/>", "<option/>", "<textarea/>",
+        "<tbody/>", "<thead/>", "<tfoot/>", "<iframe/>"
+    ];
+    for (var i = 0; i < cloneTags.length; i++) {
+        var j = $(cloneTags[i]);
+        equals( j[0].tagName, j.clone()[0].tagName, 'Clone a &lt;' + cloneTags[i].substring(1));
+    }
+
     // using contents will get comments regular, text, and comment nodes
     var cl = $("#nonnodes").contents().clone();