Changeset 5273

Timestamp:

04/21/08 20:39:17 (9 months ago)

Author:

brandon.aaron

Message:

Trigger onclick handlers of links

Location:

trunk/jquery

Files:

• src/event.js (modified) (1 diff)
• test/unit/event.js (modified) (2 diffs)

trunk/jquery/src/event.js

@@ -204 +204 @@
                 val = jQuery.data(elem, "handle").apply( elem, data );
 
-            // Handle triggering native .onfoo handlers
-            if ( !fn && elem["on"+type] && elem["on"+type].apply( elem, data ) === false )
+            // Handle triggering native .onfoo handlers (and on links since we don't call .click() for links)
+            if ( (!fn || (jQuery.nodeName(elem, 'a') && type == "click")) && elem["on"+type] && elem["on"+type].apply( elem, data ) === false )
                 val = false;
 

trunk/jquery/test/unit/event.js

@@ -114 +114 @@
 
 test("click()", function() {
-    expect(4);
+    expect(5);
     $('<li><a href="#">Change location</a></li>').prependTo('#firstUL').find('a').bind('click', function() {
         var close = $('spanx', this); // same with $(this).find('span');
@@ -132 +132 @@
     $('#firstp').click();
     ok( counter == 1, "Check that click, triggers onclick event handler also" );
+    
+    var clickCounter = 0;
+    $('#simon1')[0].onclick = function(event) {
+        clickCounter++;
+    };
+    $('#simon1').click();
+    ok( clickCounter == 1, "Check that click, triggers onclick event handler on an a tag also" );
 });