Changeset 5314

Timestamp:

04/24/08 21:23:36 (7 months ago)

Author:

joern.zaefferer

Message:

jquery core: Patch from #2619 applied, making makeArray more flexible and faster; removed hint to ticket from (previously failing) test

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/core.js (modified) (1 diff)

trunk/jquery/src/core.js

@@ -1124 +1124 @@
         var ret = [];
 
-        // Need to use typeof to fight Safari childNodes crashes
-        if ( array.constructor != Array )
-            for ( var i = 0, length = array.length; i < length; i++ )
-                ret.push( array[ i ] );
-        else
-            ret = array.slice( 0 );
+        if( array != undefined )
+            //strings and functions also have 'length'
+            if( array.length != undefined && !array.split && !array.call )
+                for( var i = array.length; i; )
+                    ret[--i] = array[i];
+            else
+                ret[0] = array;
 
         return ret;

trunk/jquery/test/unit/core.js

@@ -1563 +1563 @@
 });
 
-test("makeArray(#2619)", function(){
+test("$.makeArray", function(){
     expect(11);