Changeset 5343

Timestamp:

04/28/08 14:11:35 (4 months ago)

Author:

joern.zaefferer

Message:

jquery core: fix for #1960, delegating to document.getElementsByName for [name=...] selectors (not in combination with :not)

Files:

• trunk/jquery/src/selector.js (modified) (1 diff)

trunk/jquery/src/selector.js

@@ -332 +332 @@
 
             else if ( m[1] == "[" ) {
-                var tmp = [], type = m[3];
+                var type = m[3];
                 
-                for ( var i = 0, rl = r.length; i < rl; i++ ) {
-                    var a = r[i], z = a[ jQuery.props[m[2]] || m[2] ];
-                    
-                    if ( z == null || /href|src|selected/.test(m[2]) )
-                        z = jQuery.attr(a,m[2]) || '';
-
-                    if ( (type == "" && !!z ||
-                         type == "=" && z == m[5] ||
-                         type == "!=" && z != m[5] ||
-                         type == "^=" && z && !z.indexOf(m[5]) ||
-                         type == "$=" && z.substr(z.length - m[5].length) == m[5] ||
-                         (type == "*=" || type == "~=") && z.indexOf(m[5]) >= 0) ^ not )
-                            tmp.push( a );
+                // special case, filter by exact name
+                if ( !not && m[2] == 'name' && type == '=' )
+                    r = jQuery.grep( document.getElementsByName(m[5]), function(elem){
+                        return jQuery.inArray( elem, r ) != -1; 
+                    });
+                else {
+                    for ( var i = 0, rl = r.length, tmp = []; i < rl; i++ ) {
+                        var a = r[i], z = a[ jQuery.props[m[2]] || m[2] ];
+                        
+                        if ( z == null || /href|src|selected/.test(m[2]) )
+                            z = jQuery.attr(a,m[2]) || '';
+    
+                        if ( (type == "" && !!z ||
+                             type == "=" && z == m[5] ||
+                             type == "!=" && z != m[5] ||
+                             type == "^=" && z && !z.indexOf(m[5]) ||
+                             type == "$=" && z.substr(z.length - m[5].length) == m[5] ||
+                             (type == "*=" || type == "~=") && z.indexOf(m[5]) >= 0) ^ not )
+                                tmp.push( a );
+                    }                   
+                    r = tmp;
                 }
-                
-                r = tmp;
 
             // We can get a speed boost by handling nth-child here