Changeset 5344

Timestamp:

04/28/08 21:09:27 (7 months ago)

Author:

brandon.aaron

Message:

jQuery.event.fix performance boost. An example: click event was previously ~3ms and is now < 1ms. jQuery.event.trigger also got another small boost in performance.

Files:

• trunk/jquery/src/event.js (modified) (4 diffs)

trunk/jquery/src/event.js

@@ -185 +185 @@
             
             // Pass along a fake event
-            if ( event )
-                data.unshift( { type: type, target: elem } );
+            if ( event ) {
+                data.unshift({ 
+                    type: type, 
+                    target: elem, 
+                    preventDefault: function(){}, 
+                    stopPropagation: function(){}, 
+                    timeStamp: +new Date
+                });
+                data[0][expando] = true; // no need to fix fake event
+            }
 
             // Enforce the right trigger type
@@ -266 +274 @@
         }
 
-        // Clean up added properties in IE to prevent memory leak
-        if (jQuery.browser.msie)
-            event.target = event.preventDefault = event.stopPropagation =
-                event.handler = event.data = event[expando] = null;
-
         return val;
     },
@@ -279 +282 @@
         
         // store a copy of the original event object 
-        // and clone to set read-only properties
+        // and "clone" to set read-only properties
         var originalEvent = event;
-        event = jQuery.extend({}, originalEvent);
+        event = { originalEvent: originalEvent };
+        var props = "altKey attrChange attrName bubbles button cancelable charCode clientX clientY ctrlKey currentTarget data detail eventPhase fromElement handler keyCode metaKey newValue pageX pageY prevValue relatedNode relatedTarget screenX screenY shiftKey srcElement target timeStamp toElement type view wheelDelta which".split(" ");
+        for ( var i=props.length; i; i-- )
+            event[ props[i] ] = originalEvent[ props[i] ];
         
         // Mark it as fixed
@@ -312 +318 @@
         // check if target is a textnode (safari)
         if ( event.target.nodeType == 3 )
-            event.target = originalEvent.target.parentNode;
+            event.target = event.target.parentNode;
 
         // Add relatedTarget, if necessary