Changeset 5359

Timestamp:

04/30/08 00:19:42 (7 months ago)

Author:

malsup

Message:

Fix for ticket 2752 (don't submit when no element is selected)

Files:

• trunk/plugins/form/jquery.form.js (modified) (6 diffs)

trunk/plugins/form/jquery.form.js

@@ -1 +1 @@
 /*
  * jQuery Form Plugin
- * version: 2.07 (03/04/2008)
+ * version: 2.08 (04/29/2008)
  * @requires jQuery v1.2.2 or later
  *
@@ -11 +11 @@
  * Revision: $Id$
  */
- (function($) {
+(function($) {
+
 /**
  * ajaxSubmit() provides a mechanism for submitting an HTML form using AJAX.
@@ -178 +179 @@
  */
 $.fn.ajaxSubmit = function(options) {
+    // fast fail if nothing selected (http://dev.jquery.com/ticket/2752)
+    if (!this.length) {
+        log('ajaxSubmit: skipping submit process - no element selected');
+        return this;
+    }
+
     if (typeof options == 'function')
         options = { success: options };
@@ -190 +197 @@
     var veto = {};
     this.trigger('form-pre-serialize', [this, options, veto]);
-    if (veto.veto) return this;
+    if (veto.veto) {
+        log('ajaxSubmit: submit vetoed via form-pre-serialize trigger');
+        return this;
+   }
 
     var a = this.formToArray(options.semantic);
@@ -200 +210 @@
 
     // give pre-submit callback an opportunity to abort the submit
-    if (options.beforeSubmit && options.beforeSubmit(a, this, options) === false) return this;
+    if (options.beforeSubmit && options.beforeSubmit(a, this, options) === false) {
+        log('ajaxSubmit: submit aborted via beforeSubmit callback');
+        return this;
+    }    
 
     // fire vetoable 'validate' event
     this.trigger('form-submit-validate', [a, this, options, veto]);
-    if (veto.veto) return this;
+    if (veto.veto) {
+        log('ajaxSubmit: submit vetoed via form-submit-validate trigger');
+        return this;
+    }    
 
     var q = $.param(a);
@@ -867 +883 @@
 };
 
+// helper fn for console logging
+// set $.fn.ajaxSubmit.debug to true to enable debug logging
+function log() {
+    if ($.fn.ajaxSubmit.debug && window.console && window.console.log)
+        window.console.log('[jquery.form] ' + Array.prototype.join.call(arguments,''));
+};
+
 })(jQuery);