Changeset 5389

Timestamp:

05/03/08 01:39:27 (7 months ago)

Author:

scott.gonzalez

Message:

core: Fixed #2605: .data() now accepts null as a value.

Location:

trunk/jquery

Files:

• src/core.js (modified) (1 diff)
• test/unit/core.js (modified) (2 diffs)

trunk/jquery/src/core.js

@@ -670 +670 @@
         
         // Prevent overriding the named cache with undefined values
-        if ( data != undefined )
+        if ( data !== undefined )
             jQuery.cache[ id ][ name ] = data;
         

trunk/jquery/test/unit/core.js

@@ -1399 +1399 @@
 
 test("$.data", function() {
-    expect(3);
+    expect(5);
     var div = $("#foo")[0];
     ok( jQuery.data(div, "test") == undefined, "Check for no data exists" );
@@ -1406 +1406 @@
     jQuery.data(div, "test", "overwritten");
     ok( jQuery.data(div, "test") == "overwritten", "Check for overwritten data" );
+    jQuery.data(div, "test", undefined);
+    ok( jQuery.data(div, "test") == "overwritten", "Check that data wasn't removed");
+    jQuery.data(div, "test", null);
+    ok( jQuery.data(div, "test") === null, "Check for null data");
 });