Changeset 5657

Timestamp:

05/22/08 09:32:47 (3 months ago)

Author:

joern.zaefferer

Message:

autocomplete: Removed the blur-on-return workaround, added a less obtrusive one only for Opera

Location:

trunk/plugins/autocomplete

Files:

• changelog.txt (modified) (1 diff)
• demo/index.html (modified) (1 diff)
• jquery.autocomplete.js (modified) (3 diffs)
• todo (modified) (1 diff)

trunk/plugins/autocomplete/changelog.txt

@@ -4 +4 @@
 * Fixed ac_even class (was ac_event)
 * Fixed bgiframe usage: now its really optional
+* Removed the blur-on-return workaround, added a less obtrusive one only for Opera
 
 1.0

trunk/plugins/autocomplete/demo/index.html

@@ -241 +241 @@
             </select>
         </p>
+        
+        <input type="submit" value="Submit" />
     </form>
     

trunk/plugins/autocomplete/jquery.autocomplete.js

@@ -79 +79 @@
     var select = $.Autocompleter.Select(options, input, selectCurrent, config);
     
+    var blockSubmit;
+    
+    // prevent form submit in opera when selecting with return key
+    $.browser.opera && $(input.form).bind("submit.autocomplete", function() {
+        if (blockSubmit) {
+            blockSubmit = false;
+            return false;
+        }
+    });
+    
     $input.keydown(function(event) {
         // track last key pressed
@@ -124 +134 @@
             case KEY.TAB:
             case KEY.RETURN:
-                if( selectCurrent() ){
-                    // make sure to blur off the current field
-                    if( !options.multiple )
-                        $input.blur();
-                    event.preventDefault();
+                if( selectCurrent() ) {
+                    // stop default to prevent a form submit, Opera needs special handling
+                    if (!$.browser.opera)
+                        event.preventDefault();
+                    else
+                        blockSubmit = true;
                 }
                 break;
@@ -186 +197 @@
         select.unbind();
         $input.unbind();
+        $(input.form).unbind(".autocomplete");
     });
     

trunk/plugins/autocomplete/todo

@@ +1 @@
+- multiple + mustMatch: incorrect value deletes more then just the incorrect value -> delete only the last value
+- multiple without mustMatch: incorrect value + seperator inserts last match -> don't
+
 
 TODO