Changeset 5683 for trunk/jquery/src

Timestamp:

05/24/08 18:09:21 (8 months ago)

Author:

aflesler

Message:

jquery core: closes #2930. Normalizing attr() to return undefined, even when getting DOM attributes.

Files:

• trunk/jquery/src/core.js (modified) (2 diffs)

trunk/jquery/src/core.js

@@ -1061 +1061 @@
 
             // If applicable, access the attribute via the DOM 0 way
-            if ( notxml && !special && name in elem ) {
+            if ( name in elem && notxml && !special ) {
                 if ( set ){
                     // We can't allow the type property to be changed (since it causes problems in IE)
@@ -1084 +1084 @@
                 elem.setAttribute( name, "" + value );
 
-            if ( msie && special && notxml )
-                return elem.getAttribute( name, 2 );
-
-            return elem.getAttribute( name );
-
+            var attr = msie && notxml && special
+                    // Some attributes require a special call on IE
+                    ? elem.getAttribute( name, 2 )
+                    : elem.getAttribute( name );
+
+            // Non-existent attributes return null, we normalize to undefined
+            return attr === null ? undefined : attr;
         }