Bug Tracker

Ticket #1214 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

.show(...) doesn't always make elements visible

Reported by: arrix Assigned to: anonymous
Type: bug Priority: major
Milestone: 1.1.3 Component: fx
Version: 1.1.2 Keywords:
Cc: Needs: Review

Description

1.1.3a in IE/FF/Opera .show(...) doesn't always make elements visible. e.g. 

$('#div1').slideDown().hide().show('slow');
$('#div2').fadeIn().hide().show('slow');
$('#div3').hide('slow').show('slow');

Please test with attached file. The elements end up with style="display:none"

Attachments

jq_bug_show.zip (19.5 kB) - added by arrix 1 year ago.
fx.diff (0.7 kB) - added by brandon 1 year ago.
Patch
animations-bug.zip (38.4 kB) - added by hobbit 1 year ago.
a test file

Change History

Changed 1 year ago by arrix

follow-up: ↓ 2   Changed 1 year ago by brandon

I've attached a patch for this. The logic was reversed causing the animate method to bail out at the wrong time. However, this patch seems to break the fx test suite which I have yet to look into.

in reply to: ↑ 1 ; follow-up: ↓ 3   Changed 1 year ago by brandon

Replying to brandon:

I've attached a patch for this. The logic was reversed causing the animate method to bail out at the wrong time. However, this patch seems to break the fx test suite which I have yet to look into.

I just got totally confused on the logic. The new patch seemingly fixes the problems.

Changed 1 year ago by brandon

Patch

in reply to: ↑ 2   Changed 1 year ago by brandon

Replying to brandon:

Replying to brandon:

I've attached a patch for this. The logic was reversed causing the animate method to bail out at the wrong time. However, this patch seems to break the fx test suite which I have yet to look into.

I just got totally confused on the logic. The new patch seemingly fixes the problems.

hmmm... I'm just completely off target on this one. The current attached patch doesn't work for all test cases. If I comment out lines 311-315 in fx.js all test cases work just fine. It seems the enhancement ticket #1051 has caused more harm than good. Another good test-case for this bug can be found in #1234.

BTW... I'm pretty sure this is the bug that is causing the Tabs plugin to fail with 1.1.3a.

Changed 1 year ago by hobbit

a test file

  Changed 1 year ago by hobbit

I added a test file to the attachments: 

<html>
<head>
  <title>Test file</title>
  <style>
    #item {
      display: none;
    }
  </style>
  <script type="text/javascript" src="jquery-1.1.3a.js"></script>
  <script type="text/javascript">
  $(document).ready(function(){
    $("#item").hide(1);
  });
  </script>
</head>
<body>
  <a href="#" onclick="$('#item').show(1);">This doesn't work: show(1)</a><br>
  <a href="#" onclick="$('#item').show(0);">This works: show(0)</a><br><br>
  <a href="#" onclick="$('#item').hide(1);">This doesn't work: hide(1)</a><br>
  <a href="#" onclick="$('#item').hide(0);">This works: hide(0)</a><br><br>
  <div id="item">The animated item</div>
</body></html>

  Changed 1 year ago by john

Fixed in SVN rev [2129].

  Changed 1 year ago by john

  • status changed from new to closed
  • resolution set to fixed

  Changed 1 year ago by ah520

企业电子商务指南 数字寿州寿县门户 金信输送设备 输送机金信 工业流水线自动化流水线电动车流水线 金信输送线输送流水线] 拓野流水线 中国流水线行业网 拓野生产线 金信装配线、装配流水线] 输送设备、输送机 金信生产线生产流水线] 雅龙流水线 雅龙生产线 金信流水线 自动化装配线输送线流水线生产线 增盛流水线 和凯通电动门道闸岗亭 雅龙装配线装配流水线 台州水泵网 装配线装配流水线流水线配件 生产线组装流水线自动化流水线 输送线输送流水线皮带输送线 板链线流水线设备皮带流水线 流水线工业流水线自动化流水线 流水线装配线装配流水线涂装流水线 组装流水线自动化流水线电动车流水线 装配流水线生产流水线电子产品流水线板链线 涂装流水线包装流水线装配线 流水线设备工业流水线皮带流水线 http://www.zjlsx.com.cn/输送线生产线输送流水线 生产流水线 流水线 生产线 输送设备 生产流水线 输送机 输送线 装配线装配流水线

Note: See TracTickets for help on using tickets.