Bug Tracker

Ticket #1392 (closed bug: invalid)

Opened 17 months ago

Last modified 15 months ago

Gecko is gecko

Reported by: Jonno Owned by:
Priority: minor Milestone: 1.2.1
Component: core Version: 1.2
Keywords: Cc:
Needs: Review

Description

http://geckoisgecko.org/

Basicaly, detecting "Mozilla" is not very smart (as many, but not all, non-Mozilla browsers include Mozilla in their user agents). The only safe way I know about to reliably detect a Mozilla based browser is to look for Gecko/YYYYMMDD in the user agent (other browser may include "like Gecko", but none other include the gecko build date).

More browsers than Opera might masquerade as MSIE. The only way to reliably detect for MSIE is to use Conditional Compilation of JavaScript in IE.

The attached patch fixes these issues as well as adds support for khtml (very similar to WebKit?).

Attachments

geckoisgecko.patch (3.6 KB) - added by Jonno 17 months ago.

Change History

Changed 17 months ago by Jonno

Changed 15 months ago by john

  • status changed from new to closed
  • version changed from 1.1.3 to 1.2
  • resolution set to invalid
  • milestone changed from 1.1.4 to 1.2.1

Our current implementation works for all browsers that we support - if a user is spoofing their useragent, then they're obviously asking for that browser's specific implementation of functionality. We should not try to circumvent that.

Note: See TracTickets for help on using tickets.