Bug Tracker

Ticket #2008 (closed bug: fixed)

Opened 12 months ago

Last modified 12 months ago

[PATCH] Open and Close Multiple Dialogs

Reported by: Xichekolas Owned by: rworth
Priority: major Milestone: 1.2.2
Component: ui Version: 1.2.1
Keywords: ui dialog open close Cc:
Needs: Review

Description

Two problems:

1. All dialogs were opening with the same data. This made all the close buttons only close the most recently opened dialog. Fixed this by adding the 'new' keyword before the call to $.ui.dialogInit

2. Closing a dialog only sets it to display:none. However, reopening the dialog actually creates a whole duplicate dialog, rather than unhiding the existing one. This is because the if statement that checked to see if the div on which we call .dialog() is already a dialog was checking for the wrong css class (due to the way the dialog is built, the original div gets the .ui-dialog-content class, not the .ui-dialog class.

Attachments

ReopenPatch.diff (423 bytes) - added by Xichekolas 12 months ago.

Change History

Changed 12 months ago by Xichekolas

Changed 12 months ago by davidserduke

  • component changed from core to ui

Changed 12 months ago by rworth

  • status changed from new to assigned
  • owner set to rworth

Changed 12 months ago by rworth

  • status changed from assigned to closed
  • resolution set to fixed

Thanks for the patch. Fixed in rev4075.

Note: See TracTickets for help on using tickets.