Bug Tracker

Ticket #2101 (closed bug: fixed)

Opened 11 months ago

Last modified 11 months ago

Minor build script issues

Reported by: emartin24 Owned by:
Priority: minor Milestone: 1.2.2
Component: build Version: 1.2.1
Keywords: build, version, pack, dist Cc:
Needs: Review

Description

I found a couple of minor issues in the build scripts.

1) In version.js, the @VERSION replace will only happen for the first occurence. To make it do a global replace, the call needs to be changed to: readFile(file).replace(RegExp?("@VERSION", "g") I'm not sure if this was intentional, but if it is not a global replace, the @VERSION, currently on line 104, will not be replaced.

2) In pack.js, if the outFile is not specified as an argument, the filename will be jquerypack.js instead of jquery.pack.js. A period needs to be added to "pack.js"

Patches included.

Attachments

build-version-pack.patch (0.9 KB) - added by emartin24 11 months ago.
version.js fix for global @VERSION replacement and pack.js fix for outFile filename

Change History

Changed 11 months ago by emartin24

version.js fix for global @VERSION replacement and pack.js fix for outFile filename

Changed 11 months ago by john

  • status changed from new to closed
  • component changed from core to build
  • resolution set to fixed

Fixed in SVN rev [4442]. The @VERSION stuff is in the build file now.

Changed 11 months ago by emartin24

  • status changed from closed to reopened
  • resolution fixed deleted

It looks like the global @VERSION replacement works correctly when building with make, but not ant. The fix I suggested for version.js will correct that.

-Eric

Changed 11 months ago by joern

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in [4486].

Note: See TracTickets for help on using tickets.