Bug Tracker

Ticket #2522 (closed enhancement: fixed)

Opened 6 months ago

Last modified 5 months ago

Remove isFunction from jQuery.event.trigger

Reported by: spinal007 Assigned to: anonymous
Type: enhancement Priority: major
Milestone: 1.2.4 Component: event
Version: 1.2.3 Keywords:
Cc: Needs: Review

Description

In jQuery.event.trigger: if ( jQuery.isFunction( jQuery.data(elem, "handle") ) )

val = jQuery.data(elem, "handle").apply( elem, data );

Problem 1: That's 2 calls to jQuery.data and one possibly useless call to jQuery.isFunction.

Problem 2: Is it really necessary to check if jQuery.data(elem, "handle") is a function ? what else could it be?

Proposed change: var handle = jQuery.data(elem, "handle"); if(handle) val = handle.apply( elem, data );

Attachments

Change History

Changed 6 months ago by flesler

This proposal was made by me here: http://groups.google.com/group/jquery-dev/browse_thread/thread/8cce225d143bdbfa/ce3d4c1f616ee06c#ce3d4c1f616ee06c

It's not a genius invention, but you should mention that anyway, I think. Also linking to the original discussion thread is usually good for the devs.

Changed 5 months ago by brandon

  • status changed from new to closed
  • resolution set to fixed

Applied in Rev [5276]

Note: See TracTickets for help on using tickets.