Bug Tracker

Ticket #2802 (closed bug: fixed)

Opened 4 months ago

Last modified 4 months ago

jQuery.curCSS failes in Safari 2.x

Reported by: ebartels Assigned to: anonymous
Type: bug Priority: blocker
Milestone: 1.2.4 Component: core
Version: 1.2.3 Keywords: safari getComputedStyle type error
Cc: Needs: Test Case

Description

changeset [5274] introduces an error in Safari 2.x where calls to jQuery.curCSS will fail with a type error

Apparently, Safari 2 doesn't like the use of getComputedStyle function, introduced on line 615, in place of the full document.defaultView.getComputedStyle

Attachments

ticket2802_safari_curCSS.diff (0.7 kB) - added by ebartels 4 months ago.

Change History

Changed 4 months ago by ebartels

Changed 4 months ago by ebartels

The patch should still take advantage of the optimization from [5274], but when actually making the function call, it uses the full version to keep Safari happy.

Changed 4 months ago by flesler

  • need changed from Review to Test Case

I don't see how the optimization is kept. This needs some testing, but if fails on Safari 2, then we could have a special case where getComputedStyle is a function, that calls internally to document.defaultView.....

Only for Safari 2.x

Changed 4 months ago by flesler

  • status changed from new to closed
  • resolution set to fixed

This should be fixed now ([5609]). Could you confirm this ? I don't have Safari 2.

Reopen if it still fails.

Changed 4 months ago by klaus

Fixed - that was just in time for me. Thanks Ariel :-)

Note: See TracTickets for help on using tickets.