jQuery: The Write Less, Do More JavaScript Library

Ticket #2857 (closed bug: fixed)

Opened 3 months ago

Last modified 3 months ago

[ui.dialog] Exceptions thrown if positioning in iframe

Reported by: tyler Assigned to: paul
Type: bug Priority: critical
Milestone: 1.2.4 Component: ui
Version: 1.2.3 Keywords:
Cc: Needs: Review

Description

If you're in a less-than-stellar browser (Safari 2, IE6) that has certain security restraints on trying to set the position of "top" from inside a frame (besides it being an object) currently dialog.position() will thrown an exception that will break the entire page.

The attached patch will safely set "top" in Firefox and such, and have certain fallback behavior for browsers that have issues with iframes trying set "top".

Attachments

ui.dialog.js.patch (2.2 kB) - added by tyler 3 months ago.
this one's for real

Change History

Changed 3 months ago by tyler

this one's for real

Changed 3 months ago by tyler

Ugh, talk about overengineering, the biggest problem is that it's reassigning the top variable >_<

Changed 3 months ago by scott.gonzalez

  • status changed from new to closed
  • resolution set to fixed

Fixed in [5595]. Thanks.

Note: See TracTickets for help on using tickets.