Bug Tracker

Ticket #2947 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

Event: altKey not set

Reported by: ivan Assigned to: flesler
Type: bug Priority: minor
Milestone: 1.3 Component: event
Version: 1.2.5 Keywords:
Cc: Needs: Test Case

Description

The altKey field is not set in the Event object.

Attachments

event.js.patch (0.7 kB) - added by ivan 1 year ago.
Patch

Change History

Changed 1 year ago by ivan

Patch

Changed 1 year ago by flesler

  • need changed from Review to Test Case
  • owner set to flesler
  • status changed from new to assigned

The patch is invalid, it won't add altKey.

Can you provide a test case where we can see the altKey missing ?

Thanks

Changed 1 year ago by nostrademons

I'm getting this too. Test case:

http://dev.diffle.com/jonathan/public/jquery_bug_2947/

Ivan's patch is valid. The problem is an off-by-1 error when it's looping through the fields: it starts at props.length (which is an invalid index), and ends at i = 1. When i = 0, the loop condition is false and so it doesn't perform the iteration that would assign altKey.

Changed 1 year ago by ivan

Sorry I haven't been around. Thanks nostrademons for providing the test case and explanation.

Changed 1 year ago by flesler

  • status changed from assigned to closed
  • resolution set to fixed

Right, got it now. I actually fixed this some weeks ago, I thought it made it into 1.2.6 but now I realize it didn't :(

Could you check this with the version in the trunk ?

Please reopen if that one still fails.

Thanks.

Changed 1 year ago by flesler

This was fixed on [5707].

Note: See TracTickets for help on using tickets.