$(..).empty() leaks memory when form is first child

[jeberma]

Calling $(expr).empty() on an element who's first child is a form fails to uncache/unbind that child's data/events. I think this problem can be attributed to the following method chain:

$.empty -> $.remove -> $.add -> $.makeArray

on line 1135 the filter for array-like parameters should possibly test for form elements, as they also have a length property. It seems like the current implementation creates an array of form fields, excluding the form itself.

Please see the attached file for verification.

[jeberma]

Demonstrates uncaching issue. Run with Firebug enabled.

[flesler]

Right, this can be fixed easily.

[flesler]

This is the patch

[flesler]

Applied at [5789].