ajax error event is not being reported in some situations

[attilam]

When you are trying to call a URL that fails due to such errors as NS_ERROR_DOM_BAD_URI, the error function registered with the ajax settings is not being called.

The reason it is not called is because an exception is thrown during the call at either of the following lines:

xhr.open(type, s.url, s.async, s.username, s.password); or xhr.open(type, s.url, s.async);

To resolve this issue, wrap the above calls in a try/catch block and in the catch block call the following:

jQuery.handleError(s, xhr, null, e);

[flesler]

Could you provide a test case ? a minimalistic html file with the requires html and js to reproduce the problem. Thanks.

[nathanhammond]

Test Case

[nathanhammond]

Better Patch.

[nathanhammond]

The new patch takes care of the problem and passes all collected information to the error handler as it returns.

[flesler]

Does that test case actually cause an exception ? it seems fine to me.

[nathanhammond]

Replying to flesler:

Does that test case actually cause an exception ? it seems fine to me.

It does locally for me. It is trying to request http://jquery.com when I'm on localhost. I'm updating the patch to add a test.

[nathanhammond]

I'm having trouble figuring out why adding a test for this one is causing another test to fail to start (pass-through request object). The whole test suite works just fine without adding in the new test, so I'm obviously doing something wrong.

What I'm working off of (appears right after the error callbacks):

test("jQuery.ajax() - xhr.open error callbacks", function() {
    expect( 3 );
    stop();
    jQuery('#foo').ajaxStart(function(){
        start();
        ok( true, "ajaxStart" );
    }).ajaxStop(function(){
        ok( true, "ajaxStop" );
    }).ajaxSend(function(){
        ok( true, "ajaxSend" );
    }).ajaxComplete(function(){
        ok( true, "ajaxComplete" );
    }).ajaxError(function(){
        ok( true, "ajaxError" );
    }).ajaxSuccess(function(){
        ok( false, "ajaxSuccess" );
    });
    jQuery.ajax({
        type: "GET",
        dataType: "html",
        url: url("http://jquery.com"),
        beforeSend: function(){ ok(true, "beforeSend"); },
        success: function(){ ok(false, "success"); },
        error: function(){ ok(true, "error"); },
        complete: function(){ ok(true, "complete"); }
    });
});